Should a person feel pleased, or have a virtuous vision after offering Istikhara (guidance prayer) in order to do what he/she had offered it for?
The result of the Istikhaarah is not necessarily that a person sees something (in his dream), or feels pleased, but the most important result of the Istikhaarah is whether a person is enabled to do a given matter or not.
If the menses lasted for over than 9 to 10 days, considered menstruation?
If the duration of the bleeding does not exceed fifteen days, it is all considered menstruation, even if the usual pattern changes.
Is the niṣāb calculated based on the price of 21-karat gold, or 24-karat gold?
All praise is due to Allah, and peace and blessings be upon our master, the Messenger of Allah ﷺ.
Zakāh is obligatory on cash and on gold designated for saving or for trade, provided the total reaches the niṣāb (minimum threshold liable for zakah), and a full ḥawl (lunar year) has elapsed over it. The niṣāb is (85) grams of 24-karat gold; for 21-karat gold, the niṣāb equals (97) grams; and for 18-karat gold, it equals (113) grams.
The relied-upon position is to calculate the zakāh based on the buying price [i.e., the price the gold merchant would pay the owner to purchase the gold from him] on the day the zakāh obligation is due.
The one paying zakāh may assess/calculate the niṣāb using any of the aforementioned gold karats [i.e., he may choose whichever karat standard he wishes for the purpose of the calculation]. And Allah, the Exalted, knows best.
What is the ruling on water that contains ornamental fish — does it become impure on account of their waste?
All praise is due to Allah, and peace and blessings be upon our master the Messenger of Allah ﷺ.
The water in a pond containing ornamental fish is pure so long as it has not been altered, for a small amount of fish waste (rawth) is pardoned and overlooked — provided it does not change the water.
It is stated in Ḥāshiyat al-Jamal ʿalā Sharḥ al-Manhaj (Vol.1/P.178): "A small amount of hair from a non-edible animal is pardoned, as is a small amount of hair from a riding animal — on account of the hardship involved in avoiding it — and likewise a small amount of fish waste is pardoned, unless it alters the water." And Allah the Almighty knows best.