Should a person feel pleased, or have a virtuous vision after offering Istikhara (guidance prayer) in order to do what he/she had offered it for?
The result of the Istikhaarah is not necessarily that a person sees something (in his dream), or feels pleased, but the most important result of the Istikhaarah is whether a person is enabled to do a given matter or not.
What is the ruling on ablution if vaginal discharge is expelled, and is it impure?
If these discharges exit from the external genitalia (apparent part of the vagina), they are not impure and do not invalidate ablution. If they exit from the internal part, they are impure and do invalidate ablution. If it is uncertain whether they are from the internal or external part, they are not impure and do not invalidate ablution.
The apparent part is what becomes visible when sitting, and what the husband's penis reaches during intercourse is considered part of the apparent. The internal part is what is beyond that. And Allah the Almighty knows best.
Should missed Sunnah prayer be made up?
Making up missed voluntary acts of worship is from Sunnah.
Is the one who gives up on marriage because he can`t afford it considered sinful?
Marriage is desirable, but one who can`t afford it isn`t considered sinful. However, he should supplicate to Allah, and seek His forgiveness.