I swear that I will leave the religion of Allah if I return to smoking" and then returned to smoking. What is the ruling?
Whoever conditions disbelief on something and intends to disbelieve if it happens, he becomes a disbeliever immediately. Therefore, you must pronounce the two testimonies of faith (Shahada) and reconcile with your wife if she is in her waiting period (Iddah). It is recommended to consult the Department of Fatwa for further guidance. And Allah Knows Best.
Should a person feel pleased, or have a virtuous vision after offering Istikhara (guidance prayer) in order to do what he/she had offered it for?
The result of the Istikhaarah is not necessarily that a person sees something (in his dream), or feels pleased, but the most important result of the Istikhaarah is whether a person is enabled to do a given matter or not.
Does ill-gotten money hinder the answering of the Du`a (supplication) and the means of subsistence?
Sins hinder the answering of the Du`a, and deprive the sinner from means of subsistence; whereas, acts of obedience facilitate making a living. Allah, The Almighty, Says (What means) : "And for those who fear God, He (ever) prepares a way out. And He provides for him from (sources) he never could imagine." [At-Talaq/2-3].
Is it permissible to listen to chants praising the Prophet if accompanied by musical instruments?
If singing, or chanting in praise of the Prophet was accompanied by a forbidden musical instrument, then it is forbidden.