Should a person feel pleased, or have a virtuous vision after offering Istikhara (guidance prayer) in order to do what he/she had offered it for?
The result of the Istikhaarah is not necessarily that a person sees something (in his dream), or feels pleased, but the most important result of the Istikhaarah is whether a person is enabled to do a given matter or not.
Is it permissible for the mother to give her children from the Zakah (obligatory charity) of her money?
It is permissible for the mother to give her children from the Zakah of her money if they are Zakah-eligible recipients, and she isn`t obliged to provide for them.
What is the ruling on someone who doesn`t perform prayer?
All perfect praise be to Allah,The Lord of The Worlds Not performing prayer is a major sin, and one who doesn`t pray out of laziness is considered an oft-sinner ;whereas, the one who denies that it is mandatory is considered a disbeliever. And Allah Knows Best.
Is the one who gives up on marriage because he can`t afford it considered sinful?
Marriage is desirable, but one who can`t afford it isn`t considered sinful. However, he should supplicate to Allah, and seek His forgiveness.