Should a person feel pleased, or have a virtuous vision after offering Istikhara (guidance prayer) in order to do what he/she had offered it for?
The result of the Istikhaarah is not necessarily that a person sees something (in his dream), or feels pleased, but the most important result of the Istikhaarah is whether a person is enabled to do a given matter or not.
Does smoking break the fast?
Yes, smoking breaks the fast because smoke particles intentionally enter the lungs, which are considered part of the body cavity (jauf).
What is the ruling on brown discharge before the menstrual period? Is it considered part of menstruation (Hayd)?
Praise be to Allah, and peace and blessings be upon our Master, the Messenger of Allah.
Dusky discharge (Kudrah), reddish discharge (Humrah), and yellowish discharge (Sufrah) are all considered menstruation (Hayd) if they occur during the time of the menstrual cycle. If their duration exceeds a day and a night, and the period persists from the first sight of the discharge until the cessation of the menstrual blood—provided the total duration does not exceed fifteen days—then all of it is menstruation. However, if the duration exceeds fifteen days, then the discharge is not considered menstruation, but rather chronic irregular bleeding (Istihadah). And Allah the Exalted knows best.
Is it valid to have Suhoor before sleeping, even if it is before midnight?
Suhoor refers to the pre-dawn meal eaten after midnight to help a Muslim endure fasting. The closer it is to Fajr, the better.
The Prophet ﷺ said: "My Ummah will remain upon goodness as long as they hasten to break the fast and delay Suhoor." [Narrated by Ahmad]
This is because delaying Suhoor makes it more effective in providing strength for worship. However, if there is a risk of Fajr entering while eating, one should refrain from Suhoor out of caution.
The Prophet ﷺ said: "Leave what makes you doubt for what does not make you doubt." [Narrated by Al-Tirmidhi]