Is washing the private part after urinating (Istinjaa`) a condition, and is it done with water and soap, or with water only?
Istinjaa` is obligatory for removing impurity, and it can be done with toilet paper, or a stone, or water. It is preferable to do Istinjaa` first with paper, or stone, or the like, then to wash the private part with water until making sure that the impurity has been removed. Using soap is not a condition, but there is no harm in doing so provided that it is washed off with water. It is also permissible to use either water, or paper if impurity is removed by any.
A pious man proposed to me and my father was hesitant in this regard because he is black, am I sinful if I accepted his proposal?
If the suitor is pious, color isn`t a drawback. However, try talking to your father kindly, so that he approves of your marriage with contentment, and that is better for you.
Should nail polish be removed before making ablution?
Yes, it should be removed because it prevents water from reaching the nails.
Should a person feel pleased, or have a virtuous vision after offering Istikhara (guidance prayer) in order to do what he/she had offered it for?
The result of the Istikhaarah is not necessarily that a person sees something (in his dream), or feels pleased, but the most important result of the Istikhaarah is whether a person is enabled to do a given matter or not.