Should a person feel pleased, or have a virtuous vision after offering Istikhara (guidance prayer) in order to do what he/she had offered it for?
The result of the Istikhaarah is not necessarily that a person sees something (in his dream), or feels pleased, but the most important result of the Istikhaarah is whether a person is enabled to do a given matter or not.
What is the ruling o associations (Whereas a person who have money buys a commodity for a person and and gets a profit on it)?
It is permissible for a person to buy a commodity for someone's else and have a profit/loss on it
Is it permissible to have sexual intercourse with pregnant wife?
All perfect praise be to Allah, the Lord of the worlds. I testify that there is none worthy of worship except Allah and that Muhammad, sallallahu ‘alayhi wa sallam, is His slave and Messenger.
There is no sin in having sex with one`s pregnant wife as long as there is no medical condition preventing her from that. And Allah The Almighty Knows Best.
Is the one who gives up on marriage because he can`t afford it considered sinful?
Marriage is desirable, but one who can`t afford it isn`t considered sinful. However, he should supplicate to Allah, and seek His forgiveness.